From 32871fcc6bca0969bcbc77d2cc36e30d10111804 Mon Sep 17 00:00:00 2001 From: ArthurSonzogni Date: Sun, 30 Jun 2019 23:59:27 +0200 Subject: [PATCH] Add -Wextra --- CMakeLists.txt | 2 +- include/ftxui/component/container.hpp | 2 +- src/ftxui/component/screen_interactive.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ef876c1..7ff5875 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -68,7 +68,7 @@ foreach(lib screen dom component) PRIVATE src ) target_compile_features(${lib} PUBLIC cxx_std_17) - target_compile_options(${lib} PRIVATE -Wall) + target_compile_options(${lib} PRIVATE -Wall -Werror -Wextra) endforeach() include(GNUInstallDirs) diff --git a/include/ftxui/component/container.hpp b/include/ftxui/component/container.hpp index 270009f..97c6d20 100644 --- a/include/ftxui/component/container.hpp +++ b/include/ftxui/component/container.hpp @@ -27,7 +27,7 @@ class Container : public Component { using EventHandler = bool (Container::*)(Event); bool VerticalEvent(Event event); bool HorizontalEvent(Event event); - bool TabEvent(Event event) { return false; } + bool TabEvent(Event) { return false; } EventHandler event_handler_; using RenderHandler = Element (Container::*)(); diff --git a/src/ftxui/component/screen_interactive.cpp b/src/ftxui/component/screen_interactive.cpp index ca5ef5c..c0d8ba3 100644 --- a/src/ftxui/component/screen_interactive.cpp +++ b/src/ftxui/component/screen_interactive.cpp @@ -31,7 +31,7 @@ void OnExit(int signal) { } std::function on_resize = []{}; -void OnResize(int signal) { +void OnResize(int /* signal */) { on_resize(); }