amass/FTXUI
1
0
Fork 0
mirror of https://github.com/ArthurSonzogni/FTXUI.git synced 2024-11-26 04:31:34 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix types used in Hash() function used in tests. (#640)

Browse Source 
Using `auto` seems to create a different output on different platforms.
Notably it was observed that aarch64 compiles return a different
value.

Fix the type of the characters iterated through the string.

Fixes #639

Signed-off-by: Henner Zeller <h.zeller@acm.org>
This commit is contained in:
Henner Zeller 2023-05-17 02:59:41 -07:00 committed by GitHub
parent 6e059dadd5
commit 38827dda5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ftxui/dom/canvas_test.cpp
View File

@ -15,7 +15,7 @@ namespace ftxui {
namespace { namespace {
uint32_t Hash(const std::string s) { uint32_t Hash(const std::string s) {
uint32_t hash = 0; uint32_t hash = 0;
for (auto c : s) { for (uint8_t c : s) {
hash += c; hash += c;
hash *= 7; hash *= 7;
} }
@ -38,7 +38,7 @@ TEST(CanvasTest, GoldPoint) {
}); });
Screen screen(30, 10); Screen screen(30, 10);
Render(screen, element); Render(screen, element);
EXPECT_EQ(Hash(screen.ToString()), 2143518726); EXPECT_EQ(Hash(screen.ToString()), 2085952774U) << screen.ToString();
} }
TEST(CanvasTest, GoldPointColor) { TEST(CanvasTest, GoldPointColor) {
@ -53,7 +53,7 @@ TEST(CanvasTest, GoldPointColor) {
}); });
Screen screen(30, 10); Screen screen(30, 10);
Render(screen, element); Render(screen, element);
EXPECT_EQ(Hash(screen.ToString()), 1264423298); EXPECT_EQ(Hash(screen.ToString()), 2295070594U) << screen.ToString();
} }
TEST(CanvasTest, GoldBlock) { TEST(CanvasTest, GoldBlock) {
@ -71,7 +71,7 @@ TEST(CanvasTest, GoldBlock) {
}); });
Screen screen(30, 10); Screen screen(30, 10);
Render(screen, element); Render(screen, element);
EXPECT_EQ(Hash(screen.ToString()), 3826174883); EXPECT_EQ(Hash(screen.ToString()), 2625314979U) << screen.ToString();
} }
TEST(CanvasTest, GoldBlockColor) { TEST(CanvasTest, GoldBlockColor) {
@ -86,7 +86,7 @@ TEST(CanvasTest, GoldBlockColor) {
}); });
Screen screen(30, 10); Screen screen(30, 10);
Render(screen, element); Render(screen, element);
EXPECT_EQ(Hash(screen.ToString()), 3048712696); EXPECT_EQ(Hash(screen.ToString()), 8392696U) << screen.ToString();
} }
TEST(CanvasTest, GoldText) { TEST(CanvasTest, GoldText) {