amass/FTXUI
1
0
Fork 0
mirror of https://github.com/ArthurSonzogni/FTXUI.git synced 2024-11-26 04:31:34 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve unicode codepoint Bisearch performance (#691)

Browse Source 
Improve the performance of the functions for searching for codepoints
in a table by passing the table array in as a reference instead of copying
it.

Co-authored-by: ArthurSonzogni <sonzogniarthur@gmail.com>
This commit is contained in:
Stefan Ravn van Overeem 2023-06-27 22:32:57 +02:00 committed by GitHub
parent 455998d759
commit b2f66c7386
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ftxui/dom/benchmark_test.cpp
View File

@ -30,6 +30,19 @@ static void BencharkBasic(benchmark::State& state) {
}
BENCHMARK(BencharkBasic)->DenseRange(0, 256, 16);
static void BencharkText(benchmark::State& state) {
while (state.KeepRunning()) {
std::string content = "ＨＥＬＬＯ world ";
for(int i=0; i<state.range(0); ++i) {
content += content;
}
auto document = paragraph(content);
Screen screen(200,200);
Render(screen, document);
}
}
BENCHMARK(BencharkText)->DenseRange(0, 10, 1);
} // namespace ftxui
// NOLINTEND

4
src/ftxui/screen/string.cpp
View File

@ -1368,7 +1368,7 @@ const std::array<WordBreakPropertyInterval, 1288> g_word_break_intervals = {{
// Find a codepoint inside a sorted list of Interval.
template <size_t N>
bool Bisearch(uint32_t ucs, const std::array<Interval, N> table) {
bool Bisearch(uint32_t ucs, const std::array<Interval, N>& table) {
if (ucs < table.front().first || ucs > table.back().last) { // NOLINT
return false;
}
@ -1391,7 +1391,7 @@ bool Bisearch(uint32_t ucs, const std::array<Interval, N> table) {
// Find a value inside a sorted list of Interval + property.
template <class C, size_t N>
bool Bisearch(uint32_t ucs, const std::array<C, N> table, C* out) {
bool Bisearch(uint32_t ucs, const std::array<C, N>& table, C* out) {
if (ucs < table.front().first || ucs > table.back().last) { // NOLINT
return false;
}