Merge baa5973128 into 547d9278d8

cmake/ftxui_set_options.cmake

@@ -49,12 +49,6 @@ function(ftxui_set_options library)
     target_compile_options(${library} PUBLIC "/utf-8")
   endif()
 
-  # CMake does automatically add -fPIC when linking a shared library, but it
-  # does not add it when linking a static library. This is a problem when the 
-  # static library is later linked into a shared library. 
-  # Doing it helps some users.
-  set_property(TARGET ${library} PROPERTY POSITION_INDEPENDENT_CODE ON)
-
   # Add as many warning as possible:
   if (WIN32)
     if (MSVC)

include/ftxui/dom/table.hpp

@@ -38,7 +38,6 @@ class Table {
   Table();
   explicit Table(std::vector<std::vector<std::string>>);
   explicit Table(std::vector<std::vector<Element>>);
-  Table(std::initializer_list<std::vector<std::string>> init);
   TableSelection SelectAll();
   TableSelection SelectCell(int column, int row);
   TableSelection SelectRow(int row_index);

src/ftxui/dom/table.cpp

@@ -71,22 +71,6 @@ Table::Table(std::vector<std::vector<Element>> input) {
   Initialize(std::move(input));
 }
 
-// @brief Create a table from a list of list of string.
-// @param init The input data.
-// @ingroup dom
-Table::Table(std::initializer_list<std::vector<std::string>> init) {
-  std::vector<std::vector<Element>> input;
-  for (const auto& row : init) {
-    std::vector<Element> output_row;
-    output_row.reserve(row.size());
-    for (const auto& cell : row) {
-      output_row.push_back(text(cell));
-    }
-    input.push_back(std::move(output_row));
-  }
-  Initialize(std::move(input));
-}
-
 // private
 void Table::Initialize(std::vector<std::vector<Element>> input) {
   input_dim_y_ = static_cast<int>(input.size());

src/ftxui/dom/table_test.cpp

@@ -733,17 +733,5 @@ TEST(TableTest, Merge) {
       screen.ToString());
 }
 
-TEST(TableTest, Issue912) {
-  Table({
-      {"a"},
-  });
-  Table({
-      {"a", "b"},
-  });
-  Table({
-      {"a", "b", "c"},
-  });
-}
-
 }  // namespace ftxui
 // NOLINTEND