From 6ea6054073a3fafd4c40672aab2f85978bd4382c Mon Sep 17 00:00:00 2001 From: Xiaofeng Wang <1237906+wasphin@users.noreply.github.com> Date: Fri, 4 Mar 2022 15:07:01 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E6=9B=B4=E6=96=B0=20issue=20=E6=A8=A1?= =?UTF-8?q?=E7=89=88=E8=AF=B4=E6=98=8E?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/ISSUE_TEMPLATE/bug.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug.md b/.github/ISSUE_TEMPLATE/bug.md index 749eeb2d..4622097d 100644 --- a/.github/ISSUE_TEMPLATE/bug.md +++ b/.github/ISSUE_TEMPLATE/bug.md @@ -1,7 +1,7 @@ --- name: bug 反馈 about: 反馈 ZLMediaKit 代码本身的 bug -title: "[BUG]: " +title: "[BUG]: BUG 现象描述" labels: bug assignees: '' @@ -11,6 +11,7 @@ assignees: '' 请仔细阅读相关注释提示, 请务必根据提示填写相关信息. 1. 信息不完整会影响问题的解决速度. 1. 乱七八糟的渲染格式也会影响开发者心情, 同样会影响问题的解决. 提交前请务必点击 Preview/预览下反馈的显示效果. + 1. 不要删除模版内容, 模版的注释部分的内容不会显示,不需要删除,直接在各部分注释外面补充相关信息即可. -->
@@ -55,6 +58,8 @@ assignees: ''
From cd4e772985583296363f28d41f6e6c0ea4bd94cf Mon Sep 17 00:00:00 2001 From: zx Date: Fri, 4 Mar 2022 16:18:26 +0800 Subject: [PATCH 2/2] remove dumplicate line `rtc_media.type` remove dumplicate line `rtc_media.type = mline.type;` --- webrtc/Sdp.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/webrtc/Sdp.cpp b/webrtc/Sdp.cpp index 731d79e8..e7e5cdb0 100644 --- a/webrtc/Sdp.cpp +++ b/webrtc/Sdp.cpp @@ -779,7 +779,6 @@ void RtcSession::loadFrom(const string &str) { auto mline = media.getItemClass('m'); this->media.emplace_back(); auto &rtc_media = this->media.back(); - rtc_media.type = mline.type; rtc_media.mid = media.getStringItem('a', "mid"); rtc_media.proto = mline.proto; rtc_media.type = mline.type;